search

Kunena / Kunena-Forum

Kunena Forum - Forum / Bulletin Board / Discussions component for Joomla - This is the 6.x/5.x main development branch. Please do not open issues regarding earlier versions of Kunena
https://www.kunena.org
GNU General Public License v3.0
1.75k stars 812 forks source link

A thumbnail is displayed even though an image has been inserted into the post. #9722

Closed rich20 closed 1 week ago

rich20 commented 1 month ago

Describe the bug https://www.kunena.org/forum/36-German/168536-kunena-6-3-4-platzhalter-thumbnails-in-beitr%C3%A4gen-eingef%C3%BCgten-bildern#231957 Confirmed

To ReproduceInsert a picture into a message and you will see it

Expected behavior No thumbnail

Actual result The thumbnail is displayed

Additional context This problem exists since K 6.3.4 https://github.com/Kunena/Kunena-Forum/issues/9697#issuecomment-2293060993

System information

Desktop

Pinkeltje commented 1 month ago

Furthermore the displayed attachments (thumbnails) have the wrong layout.

Pinkeltje commented 2 weeks ago

Better, but now buttons are pushed to the right. 2024-09-11 Screenshot 579

Or even disappear behing Last edit bar when message has been edited.

2024-09-11 Screenshot 580

Pinkeltje commented 2 weeks ago

For what it is worth: A thumbnail has always been displayed in this case. Screenshot from Joomla 3 with Kunena 5.2.14 and Crypsis. 2024-09-12 Screenshot 582

Pinkeltje commented 1 week ago

Don't think this is an improvement. I goes wrong when inline attachment is removed from message. Furthermore layout is little bit off as it still shows <div class="card pb-3 pd-3 mb-3">

Uploaded 2 attachments 2024-09-21 Screenshot 612 Inserted attachments in message 2024-09-21 Screenshot 610 Result: both attachments shown in message 2024-09-21 Screenshot 609 Removed inline attachment from message 2024-09-21 Screenshot 611 Result when removed from message 2024-09-21 Screenshot 608

xillibit commented 1 week ago

yes it remove the attachment on list below the message but it keeps the bbcode in the message

Pinkeltje commented 1 week ago

Tested with K 6.3.5. Now when removing attachment entire message text is gone and replaced by true 2024-09-23 Screenshot 614 Result after removing attachment 2024-09-23 Screenshot 616

Ruud68 commented 1 week ago

Can confirm, just ran into this issue on my own site.

and another issue: I saw the message was replaced with true so I didn't save the message but did a 'cancel'. This retained the message itself but the attachment was deleted.

That makes me wonder if that is correct? IMO The attachment should be deleted upon saving the message and not upon clicking delete on the attachment. Doing it that way will actually make you cancel the changes you did.

I know that this is not a bug but probably by 'design' but wanted to report it anyway :)

xillibit commented 1 week ago

Tested with K 6.3.5. Now when removing attachment entire message text is gone and replaced by true I had made this change : https://github.com/Kunena/Kunena-Forum/commit/c80df4d95311ec9cec26e53e93c47d0fa0723854

@Ruud68 : yes it's a bug, there is already an issue for it : https://github.com/Kunena/Kunena-Forum/issues/9730

Ruud68 commented 1 week ago

Tested with K 6.3.5. Now when removing attachment entire message text is gone and replaced by true I had made this change : c80df4d

@Ruud68 : yes it's a bug, there is already an issue for it : #9730

I think this is different: what expect is that when I click the remove attachment button, the attachment is only removed once the message is saved and not when saving the message is cancelled.