KungFuFurby / AddMusicKFF

Fork of AddMusicK, a compiler/inserter of music for Super Mario World
23 stars 15 forks source link

Type 3 Remote Code Event (on key off) fails to fire after a one-tick note #356

Open KungFuFurby opened 1 year ago

KungFuFurby commented 1 year ago

Reported by masterlink on the SNESLab Discord server. A type 3 remote code event can fail to fire on a rest put after a one-tick note. In this case, the rest will simply fail to work at all, leaving the note running until the next note is called after being forcibly keyed off.

This has been identified as being due to the type 3 remote code event being fired in readahead. Key offs are skipped when the rest VCMD is read, but readahead never fires because $70+x gets decremented before doing anything.