KungFuFurby / AddMusicKFF

Fork of AddMusicK, a compiler/inserter of music for Super Mario World
23 stars 15 forks source link

Incorrect number of readahead bytes for the Tremolo ($E5) VCMD #392

Open KungFuFurby opened 1 year ago

KungFuFurby commented 1 year ago

Reported by spooonsss on the SMWCentral Discord server. This automatically qualifies as a hot patch.

The tremolo VCMD ($E5) has an incorrect number of bytes specified in the readahead. This can cause the amplitude to accidentally read out as another VCMD under the wrong conditions.

This only affects AddmusicK: all other Addmusics and vanilla SMW are not affected by this readahead bug. However, for carol's MORE.bin and Addmusic405, they are affected by a different readahead bug because of the use of the $E5 command as a sample load command: that's $03 bytes instead of $04 bytes.