KungFuFurby / AddMusicKFF

Fork of AddMusicK, a compiler/inserter of music for Super Mario World
23 stars 15 forks source link

Avoid enabling NMI during V-Blank after uploading #428

Closed KungFuFurby closed 3 months ago

KungFuFurby commented 4 months ago

Contributed by Yoshifanatic. This prevents song uploading from re-enabling NMI during V-Blank by ensuring that V-Blank was not only not active, but also not about to occur. As a side effect of doing this, the upload time does increase by a frame for safety reasons, but it also ensures that certain sensitive operations set up during V-Blank, such as HDMA, don't get interfered with.

This commit closes https://github.com/KungFuFurby/AddMusicKFF/issues/426.