search

Kungsgeten / yankpad

Paste snippets from an org-mode file
MIT License
216 stars 18 forks source link

new X-at-point whichs allow all non-blank char #73

Closed yuchen-lea closed 3 years ago

yuchen-lea commented 4 years ago

This commit changes symbol-at-point as you suuggested to support all non-blank char as keyword, including < of course.

related Issue: https://github.com/Kungsgeten/yankpad/issues/67

First time to do this on github, if I did anything inappropriate, just tell me ;)

isamert commented 3 years ago

I tried this patch and it works quite fine. Currently I'm using yasnippet snippets alongside with yankpad because yankpad does not support keywords with non-ascii chars while yasnippet supports it. Any reason for not including this @Kungsgeten?

Kungsgeten commented 3 years ago

@isamert I intended to try this patch but then forgot about it. The submitted code needs some minor tweaks in order to conform with the Emacs Lisp code standards, but otherwise there's no reason not to include it (if it works). I've recently moved to a new apartment and will be a first time father in about a month, so unfortunately my Emacs packages have a lower priority at the moment.

isamert commented 3 years ago

I see, thanks! Just wanted to give you a friendly nudge.

I'm aware that it needs minor tweaks (and some edge cases might need handling, I saw a minor issue while using it). Maybe @yuchen-lea can clear things up (and I can give some feedback), or I can also just clear things up to ease up your work. No rush tho, I patched in my local and using it. Seems like you are not going to do much with this package for a while, so there is no maintenance burden on my side.

Oh, by the way, congratulations on being father!

Kungsgeten commented 3 years ago

Seems to work fine, though I will refactor a bit and fix an issue I noticed (not related to the PR).