search

Kunstmaan / BootstrapCK-Skin

The BootstrapCK-Skin is a skin for CKEditor based on Twitter Bootstrap styles.
http://kunstmaan.github.com/BootstrapCK-Skin/
MIT License
106 stars 27 forks source link

Not compatible with CKEDITOR 4 #6

Closed jcreamer898 closed 10 years ago

jcreamer898 commented 11 years ago

This skin is not compatible with CKEDITOR4's new API.

http://docs.ckeditor.com/#!/guide/dev_api_changes

Uncaught TypeError: Cannot call method 'add' of undefined

I assume a new branch of the skin or something will have to happen, just thought I'd give you a heads up.

Thanks!

daanporon commented 11 years ago

we can't put an exact date on when we will release a new version for this ...

feel free to fork the repo and submit a pull request, we'll be happy to review it!

jcreamer898 commented 11 years ago

Great, is there an un-minified version of skin.js anywhere?

daanporon commented 11 years ago

I unminified the skin.js file ...

Most of our changes are in the css files, the skin.js file was copied from the default kama skin and we renamed a few things in this file to 'BootstrapCK-Skin' so maybe you can take a look at the kama skin for CKEditor 4.0.

jcreamer898 commented 11 years ago

Good deal, I'll take a look!

pierrocknroll commented 10 years ago

Any update ?

d3mcfadden commented 10 years ago

I have opened a pull request for upgraded this skin to work with CKEditor 4.x (with some caveats).

https://github.com/Kunstmaan/BootstrapCK-Skin/pull/8

If @daanporon could take a look that would be appreciated.

roderik commented 10 years ago

@d3mcfadden Thanks It just happens to be that @indrikenens who made the v3 version started yesterday on a v4 version with grunt/sass added for styling. There is no code pushed yet but will follow shortly. She will definitely use your pull request!

d3mcfadden commented 10 years ago

Sounds good @roderik we use this skin in our app and we are forced to upgrade it to the latest version, so this was necessary for me to get done.

I made small(ish) commits outlining most of the CSS rule changes I had to make, so that should be helpful.

indrikenens commented 10 years ago

Hi, i just finished the skin for CKeditor4. You can find it here: https://github.com/Kunstmaan/BootstrapCK4-Skin

We're going to leave this repository as it is for people wanting to use the CK3 skin.