Kunstmaan / KunstmaanBundlesCMS

An advanced yet user-friendly content management system, based on the full stack Symfony framework combined with a whole host of community bundles. It provides a full featured, multi-language CMS system with an innovative page and form assembling process, versioning, workflow, translation and media managers and much more.
https://kunstmaancms.be
MIT License
402 stars 186 forks source link

Can you folks split the livereload bundle out? #141

Closed ghost closed 7 years ago

ghost commented 9 years ago

This bundle seems to have no dependencies on the rest of the kunstmaan bundles. Is it possible that it can be split out and have its own release schedule?

I have quite a few PRs i'd like to submit against it, but i i wouldn't want to be tied up to the overall release schedule of the rest of your CMS bundles.

roderik commented 9 years ago

Don't worry about it, since changes here don't bring bc breaks for the base cms we can tag point releases quite easily.

ghost commented 9 years ago

so, you're ok with breaking BC in the bundle?

I'd like to drop the server and port options in favor of server_url and script_url, as the current way makes it problematic to use the livereload server when your dev environment is SSL and you are proxying through your webserver.

ghost commented 9 years ago

I had done most of the work on the split bundle repository, so I'd like a bit of review before i bother submitting it as a PR.

I also have some questions:

Here is a link to the branch comparison of all the changes: https://github.com/jrobeson/KunstmaanLiveReloadBundle/compare/devel?expand=1

ghost commented 9 years ago

a guzzle 5.x dependency would require php 5.4, i wonder if there is some way i can make guzzle 3.* do the right thing with ssl.

EDIT: the right thing is being able to use the system certificate store, where if a local dev CA added that guzzle doesn't seem to know about.

ghost commented 9 years ago

i tried playing with various options with setSslVerification, but i couldn't get it to work right.

When will Kunstmaan bump to php 5.4 ?

jockri commented 7 years ago

It will be removed in in v4