Kunstmaan / KunstmaanBundlesCMS

An advanced yet user-friendly content management system, based on the full stack Symfony framework combined with a whole host of community bundles. It provides a full featured, multi-language CMS system with an innovative page and form assembling process, versioning, workflow, translation and media managers and much more.
https://kunstmaancms.be
MIT License
402 stars 186 forks source link

Issues with new toolbar helpers #1713

Closed wesleylancel closed 6 years ago

wesleylancel commented 6 years ago

I just tried turning on the new toolbar helpers (on the 5.0 branch) using

kunstmaan_admin:
    enable_toolbar_helper: true

but all I'm getting is: An error occurred while loading the web debug toolbar. Open the web profiler..

Also, it seems that the translator datacollector overrides Symfony's one, causing that part of the original profiler to be disabled.

Devolicious commented 6 years ago

@wesleylancel, that's strange because that should be the only thing that you have to do. Did you get this on a new project or on an existing one?

wesleylancel commented 6 years ago

@Devolicious tried two existing projects. They don't have anything special regarding to the toolbar though.

cv65kr commented 6 years ago

Check logs var/logs/dev.log and try establish what is wrong or give our more informations.

wesleylancel commented 6 years ago

Found this in my logs:

[2017-11-30 09:35:45] request.CRITICAL: Uncaught PHP Exception Twig_Error_Runtime: "Variable "data" does not exist." at /vendor/kunstmaan/bundles-cms/src/Kunstmaan/AdminBundle/Resources/views/Toolbar/bundles_version.html.twig line 10 {"exception":"[object] (Twig_Error_Runtime(code: 0): Variable \"data\" does not exist. at /vendor/kunstmaan/bundles-cms/src/Kunstmaan/AdminBundle/Resources/views/Toolbar/bundles_version.html.twig:10)"} {"file":"/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php","line":89,"class":"Symfony\\Component\\HttpKernel\\EventListener\\ExceptionListener","function":"logException"}
cv65kr commented 6 years ago

@wesleylancel, do You tried clear cache?

wesleylancel commented 6 years ago

Yes, but it doesn't seem to help.

We do have the version checker disabled, does the toolbar check this?

sandergo90 commented 6 years ago

@wesleylancel In the isEnabled function of the BundleVersionDataCollector there is a check for this.

cv65kr commented 6 years ago

@sandergo90 yes, indeed

wesleylancel commented 6 years ago

Okay, so that shouldn't be an issue then. Not sure what's happening then.

cv65kr commented 6 years ago

@wesleylancel, @sandergo90 i sent fix for this.