search

Kunstmaan / KunstmaanBundlesCMS

An advanced yet user-friendly content management system, based on the full stack Symfony framework combined with a whole host of community bundles. It provides a full featured, multi-language CMS system with an innovative page and form assembling process, versioning, workflow, translation and media managers and much more.
https://kunstmaancms.be
MIT License
402 stars 186 forks source link

[AdminBundle] + [DashboardBundle] upgrade to 5.1.0 breaks templates #2194

Closed SpadXIII closed 5 years ago

SpadXIII commented 5 years ago

The error is: Unable to find template "@KunstmaanDashboard/google_analytics/widget.html.twig" (looked into: /../dataplace/vendor/kunstmaan/bundles-cms/src/Kunstmaan/DashboardBundle/Resources/views).

Looks like the latest sensio/framework-extra-bundle has a backwards incompatible change to how it generates template filenames

I'm sure it is happening everywhere in the project.

acrobat commented 5 years ago

@SpadXIII Thanks for reporting! I will create a PR to fix this BC break

SpadXIII commented 5 years ago

@acrobat the same issue happens in the AdminBundle when you go to the settings. The template KunstmaanAdminBundle:Settings:index.html.twig cannot be found (in SettingsController)

acrobat commented 5 years ago

@SpadXIII I didn't have any issues with the settings page, but I've replace extra cases where the template was "guessed" to avoid issues and make the used template more explicit. Can you please test the patch provided in #2195. Thanks!

acrobat commented 5 years ago

PR #2195 is merged