search

Kunstmaan / KunstmaanBundlesCMS

An advanced yet user-friendly content management system, based on the full stack Symfony framework combined with a whole host of community bundles. It provides a full featured, multi-language CMS system with an innovative page and form assembling process, versioning, workflow, translation and media managers and much more.
https://kunstmaancms.be
MIT License
399 stars 188 forks source link

[NodeSearchBundle] Children not reindex when changing slug #2984

Open dannyvw opened 2 years ago

dannyvw commented 2 years ago

If you have a parent node with a few children nodes and you want to change the slug for the parent node then the child nodes will not be reindexed. The slug for the child nodes are now broken.

In https://github.com/Kunstmaan/KunstmaanBundlesCMS/blob/master/src/Kunstmaan/NodeSearchBundle/EventListener/NodeIndexUpdateEventListener.php#L61 the nodeTranslationId will be overwritten for every child node. The check on https://github.com/Kunstmaan/KunstmaanBundlesCMS/blob/master/src/Kunstmaan/NodeSearchBundle/EventListener/NodeIndexUpdateEventListener.php#L76 will be false and child nodes will not be reindex.

Maybe it has something to do with https://github.com/Kunstmaan/KunstmaanBundlesCMS/issues/2959?

acrobat commented 2 years ago

@dannyvw Is it a action in custom script you execute or through the admin interface?

dannyvw commented 2 years ago

@acrobat Through the admin interface

acrobat commented 2 years ago

Ok, can you share the symfony, kunstmaan cms en doctrine (doctrine orm and bundle) versions? Hopefully we can somehow see a pattern in versions with #2959

dannyvw commented 2 years ago

Symfony 4.4.31 (for most packages) Kunstmaan CMS 5.8 Doctrine ORM 2.7.5 Doctrine Bundle 1.12.13