Kunstmaan / KunstmaanBundlesCMS

An advanced yet user-friendly content management system, based on the full stack Symfony framework combined with a whole host of community bundles. It provides a full featured, multi-language CMS system with an innovative page and form assembling process, versioning, workflow, translation and media managers and much more.
https://kunstmaancms.be
MIT License
402 stars 186 forks source link

Migrate to Gulp instead of Assetic #676

Closed jverdeyen closed 6 years ago

jverdeyen commented 8 years ago

Is it an option to build all the assets with a custom Gulpfile? A main project Gulpfile can include all Gulpfile from specific bundles.

I'm currently using this custom Guplfile to pre-build the assets, as they will almost never change during developement.

https://gist.github.com/jverdeyen/ba8471307f2589a3d85b

Overruling templates an adding the static assets it trivial for example in app/Resources/KunstmaanAdminBundle/views/Default/_css.html.twig

<link rel="stylesheet" href="{{ asset('/css/admin.min.css') }}">

Can I open this discussion? Any suggestions? Any remarks?

vizo commented 8 years ago

:+1:

roderik commented 8 years ago

This is fine, we tried to keep the backend without extra gulp dependency, but in reality you always need it.

jverdeyen commented 8 years ago

In order to remove the Assetic bundle, how do you guys see this implemented? A gulpfile with settings/tasks per bundle and add css/js in Resources/public. Pre-pack these files in the repo can speed up the CMS install process and lower the number of requirements.

wesleylancel commented 8 years ago

Bumping this. Any suggestions or remarks from the Kunstmaan team? /cc @jockri @diskwriter

diskwriter commented 8 years ago

@wesleylancel I discussed this with @jockri yesterday. It's on our roadmap. I'll keep you posted on the progress!

jverdeyen commented 8 years ago

Nice! 🚀

Perni1984 commented 7 years ago

@diskwriter @jockri: as this thread is fairly old, but has now been rescheduled to 4.1 - can we help anyhow?

I am using Kunstmaan as underlying base for a project of mine, which I needed to rewrite also on the backend quite a bit. The current assetic architecture makes this kind of hard (especially in conjunction with the bower dependencies in the different bundles) - I eventually need to rewrite the asset management part anyway to stay clean in my architecture. Any input from you how you would like to have that implemented? (e.g. how to manage the bower dependencies, etc.)

mlebkowski commented 7 years ago

For an end user, KunstmaanBundles is just a library. They shouldn’t have to compile its assets, the lib should be shipped with them compiled already, in my opinion. BTW, the first thing I do in a new kunstmaan project is assetic:dump, commit the generated files to the repository and never do it again unless I update one of the bundles.

diskwriter commented 7 years ago

@Perni1984 We are currently working hard on something that will allow the use of Gulp instead of assetic in the bundles. The project was on hold for a while but we've recently restarted developing it and expect it to be ready soon. @mlebkowski is right though: The lib should be shipped with the assets already compiled, this will also be resolved once we're finished and should fix your bower-dependency issue.

Perni1984 commented 7 years ago

@mlebkowski: as assetic is not bundled with symfony anymore since 3.0 (or was it 2.8?), this will change in the future @diskwriter: I appreciate that the project has been restarted.

Perni1984 commented 7 years ago

@diskwriter: is there a public branch that I could have a look into so I understand in which direction your development is heading so I can consider this in my upcoming projects?

Perni1984 commented 7 years ago

is there any update on this? can we contribute somehow?

Devolicious commented 7 years ago

Hi @Perni1984,

We're currently busy with our roadmap. We'll notify you when it's online. But we want to handle this issue in small steps. So first task would be to have compiled assets. Next steps will become clear once the roadmap is online. Help would be much appreciated.

Perni1984 commented 7 years ago

@Devolicious: looking forward to the roadmap then.