Shell helper doesn't work on Mac OSX

[henrypenny]

I'm on OSX 10.10.5 and the Shell helper isn't working as expected.

I've removed nohup from:

vendor/kunstmaan/bundles-cms/src/Kunstmaan/UtilitiesBundle/Helper/Shell/Shell.php:22

and this solves it for my setup. Is there a good way to detect if its running on Mac and put a switch in place?

[mlebkowski]

You can override this utility in your application.

class OsxShellHelper extends Shell {
    public function runInBackground($command, $priority = 0) {
       // custom logic
    }
}

And in your config.yml:

parameters:
   kunstmaan_utilities.shell.class: OsxShellHelper

[whitewhidow]

perhaps we can check if nohup is present on the system, by dong something like this:

    $try = shell_exec("nohup date");
    if ($try !== null) {
        //nohup is working 
    } else {
        //nohup is not working
    }

[henrypenny]

@whitewhidow Feature detection might be a little more robust?

[whitewhidow]

@henrypenny what exactly do you mean by 'Feature detection' ?

[henrypenny]

As per your suggested solution: testing whether a given feature (nohup) is available as opposed to assuming that OSX doesn't have it. Might there be other OSs without nohup? Or perhaps someone will add it via homebrew in the future.

[wesleylancel]

It seems my OSX does have nohup. Maybe just test with which nohup?

[whitewhidow]

yep that seems like a nice solution ..

[kimausloos]

The use of which for this kind of thing should be avoided for various reasons, there are alternatives though: http://stackoverflow.com/a/677212

[delboy1978uk]

We don't need nohup. If we use popen() or proc_open() to run the command, then the process is already backgrounded :-) http://php.net/manual/en/function.popen.php http://php.net/manual/en/function.proc-open.php

[Numkil]

The problem should be resolved in master branch. Instead of using shell_exec we are now using the Symfony Process object. Process does use proc_open as mentioned in the above comment. This completely negates the necessity for nohup and removes any platform specific code.