search

Kunstmaan / kStrano

kStrano (KumaStrano) is a Capistrano deployment “recipe” for Kunstmaan specific applications to make our job of deploying a lot easier. It integrates with Airbrake, Jenkins and Campfire.
MIT License
13 stars 0 forks source link

Make npm/bower/grunt stuff optional by default #33

Closed SpoBo closed 11 years ago

SpoBo commented 11 years ago

It's not clear that you have to add:

set :npm_install, false set :bower_install, false set :grunt_build, false

to deploy.rb if you don't want any of this. The problem is that the deploy fails when it can't find a bower.json or package.json etc. Either it should check off it they exist and if not do nothing (dangerous beacuse you might assume it worked correctly even though your configuration is wrong) or disable it by default and only run the logic when requested in deploy.rb. In that case it can throw an exception when it can't find dependencies.

daanporon commented 11 years ago

fixed, update the gem to kstrano-1.1.3 ... now the options are disabled by default when running kumafy the options will be added to your deploy.rb and enabled. So for older projects you can remove the options there.

SpoBo commented 11 years ago

Nice :) Good solution.

daanporon commented 11 years ago

Readme updated to describe the npm_install, bower_install and grunt_build options