search

Kunzisoft / KeePassDX

Lightweight vault and password manager for Android, KeePassDX allows editing encrypted data in a single file in KeePass format and fill in the forms in a secure way.
https://www.keepassdx.com/
GNU General Public License v3.0
4.35k stars 262 forks source link

Advanced unlocking is broken #1029

Closed dmework closed 2 years ago

dmework commented 3 years ago

Describe the bug Advanced unlocking is broken when using "device credential unlocking"in Version: 2.10.3 and 2.10.4

J-Jamet commented 3 years ago

Not precise enough. I just tested with this version and it works without any problem.

dmework commented 3 years ago

I am using a PIN as a lock did you try that Thanks

shadow00 commented 3 years ago

@J-Jamet I've just updated from 2.10.1 to 2.10.4 on F-Droid and QuickUnlock doesn't work at all. I'm using QuickUnlock with the pattern unlock.

When I try to open my db with QuickUnlock it prompts me for my pattern and then it goes back to the unlock screen as if nothing happened - only now the quickunlock button is gone. The password is still "typed in" though, so opening the db with the Open button at the bottom of the screen works fine.

Switching to another app and then back to KPDX will make the quickunlock button reappear, but the password does not get saved.

J-Jamet commented 3 years ago

There is no Quick Unlock in KeePassDX. https://github.com/Kunzisoft/KeePassDX/wiki/Advanced-Unlocking#why-not-quick-unlock

I tested again with my configuration and on emulator and I have no problem. Can you tell me what configuration you have? (Device, Android, etc...)

hostops commented 3 years ago

I have the same problem with the new version. With previous version everything was working as expected. Now, credentials just do not get stored. When I try to store master password using advanced unlocking, it asks me for my swipe pattern, and then I can unlock using "Open" button. The next time I try to log in, it still says "This database does not have stored credentials yet" and I can repeat the process.

I am using OnePlus One with Lineage OS and MicroG instead of google services, but I do not think this is the problem, since previous version was working just fine.

J-Jamet commented 3 years ago

I have an idea of the issue : Fixing the #1018 bug should have an impact on older versions of the API but I need to know what version of Android you are using.

Important note: The description of a bug is important, if I test with little information (less than one description line) and it works for me, I don't go any further because I have a lot to do. The more precise you are, the better I can identify and solve the problem quickly, so don't hesitate to indicate your complete configuration at the beginning to solve the problem.

shadow00 commented 3 years ago

Yeah sorry, I was referring to the Advanced Unlock feature.

Running KPDX 2.10.4 on a Samsung Note 9, Android 8.1

Before updating to 2.10.4, I was running 2.10.1 and everything was fine.

Let me know if you need any additional information

hostops commented 3 years ago

Hi! I am using android 10 on lineage OS 17.1. I am also using MicroG 0.2.17.204714 Application was installed using F-Droid.

J-Jamet commented 3 years ago

OK, Thanks, I have identified the problem, I am making a patch. It was because of the new code of #1018. The problem is reproducible only on devices below Android R with device credential unlocking, but work well for biometric unlocking.

hostops commented 3 years ago

Wow, good job! When can we expect a new release to be published?

J-Jamet commented 3 years ago

I would like to solve problem #1028 before building the new version. If I can't, I'll put the beta online tomorrow.

J-Jamet commented 3 years ago

Version 2.10.5 has been uploaded to the Play Store test channel. Tell me if it works for you?

dmework commented 3 years ago

I can confirm it's working now

bushrang3r commented 2 years ago

This issue is happening again for me.

  1. Start the app and go to settings and switch on Device credential unlocking in Advanced unlocking
  2. Go back to login screen, enter password, tap the top middle button to enter lock pattern, touch the first dot in the sequence to unlock and the system ui (not the keepass app) crashes and the phone screen locks.

Keepass 3.0.0_beta02 Android 11 (Lineage 18.1) OnePlus7T

bushrang3r commented 2 years ago

Oops, this may not be a Keepass problem. I'm trying to unlock other apps (on my new phone) with pattern unlock credentials and the same system ui crash is occurring.

bushrang3r commented 2 years ago

I'm sorry Jeremy, I don't know if this bug is related to Keepass or not, so I've attached logs. When I try to use the pattern lock to unlock the app, the system ui crashes. I hope you can see where the problem lies. The bug was present for me on 3.0.0_beta02 as I stated above, and now I'm on 3.0.0 and the same bug persists.

2021-09-11-21-09-52.txt