Kunzisoft / KeePassDX

Lightweight vault and password manager for Android, KeePassDX allows editing encrypted data in a single file in KeePass format and fill in the forms in a secure way.
https://www.keepassdx.com/
GNU General Public License v3.0
4.28k stars 261 forks source link

Bump project dependencies and minSDK to 29 (Android 10) #1825

Closed NorthernMagic closed 1 month ago

NorthernMagic commented 1 month ago

This controversal PR is mostly a small maintenance one, but with a couple of big changes when it comes to compatibility with Android versions below Quincetart (10).

Many of the project dependencies have been upgraded in preparation to targeting SDK 34 (14).

The minSDK has been bumped to 29, and lots of applicable obselete version checking and handling code has been removed.

While mostly a non-functional change that decreases compatibility with older Android releases. Some of the upgraded dependencies now don't support minSDKs below 21 (5) officially. Many apps in the security and privacy space that are built for Android are also receiving a degree of pressure to support more secure Android releases only, from their users. https://github.com/Kunzisoft/KeePassDX/issues/1730 https://github.com/mollyim/mollyim-android/issues/108

As for why Android 10 being the cutoff. It seemed to be the best balance. Any more aggressive, and major percentages of the KeePassDX userbase could be potentially left out.

Samples from across the internet, such as the Android Studio SDK distribution, generally show that a small percentage of the entire Android userbase (while still millions of people) who use these older, insecure versions, are migrating away from them. Making supporting them for longer, make less sense as time goes on and ultimately holds back the project. image

Review the commits and please leave feedback if anything blocks this PR in particular and/or if other development plans are occuring. Thank you. :)

NorthernMagic commented 1 month ago

I'm retracting this. Due to unpopularity with the latter.