Kunzisoft / KeePassDX

Lightweight vault and password manager for Android, KeePassDX allows editing encrypted data in a single file in KeePass format and fill in the forms in a secure way.
https://www.keepassdx.com/
GNU General Public License v3.0
4.49k stars 266 forks source link

Is there a Code Style Guide #184

Open studio315b opened 5 years ago

studio315b commented 5 years ago

I'm working on a PR for KeePassDX, and I auto-format code (because I don't trust myself to keep standard formatting), but I've noticed my formatter changing a line or two that I didn't write. Before I send a PR with a few formatting clean ups, I wanted to know if there's a specific set of formatting rules I should be applying.

J-Jamet commented 5 years ago

Not really, but you're right, it would be nice to make rules for formatting. I just made lot of changes from the KeePassDroid project that was on Eclipse, so there are tabbing issues, and so on. If you have rules that you want to apply, you can tell me which ones, to see if we can apply them to the whole project.

studio315b commented 5 years ago

As an easy first step, we can adopt Google's style guide. It has preexisting definitions for IntelliJ, Android Studio, Eclipse, and VSCode. Given the ubiquity of Google's developers, I'd be willing to bet that there are existing vim and emacs presets as well.