Kunzisoft / KeePassDX

Lightweight vault and password manager for Android, KeePassDX allows editing encrypted data in a single file in KeePass format and fill in the forms in a secure way.
https://www.keepassdx.com/
GNU General Public License v3.0
4.69k stars 275 forks source link

Autofill based on domain/url in Firefox for Android 11 #702

Closed nils-one closed 4 years ago

nils-one commented 4 years ago

First of all, thank you so much for your great work!

Description I have a problem with autofill within the firefox browser. It looks like KeePassDX is only looking for the AppID (org.mozilla.firefox) but not for the opened Domain. But I think firefox is offering the domain, because other password apps i.e. Bitwarden autofills forms based on URL without problems.

Steps to reproduce

  1. Open actual Firefox for Android.
  2. Go to any webpage with a login form with a matching password and url within opened kdbx database.
  3. Click on the autofill overlay.
  4. The app looks for an entry with the AppID org.mozilla.firefox

Expected behavior The app should look for the entries with matching urls and not matching AppIDs

Keepass Database

KeePassDX:

Android:

Additional context

J-Jamet commented 4 years ago

Are you sure you have not activated the accessibility service on Bitwarden?

nils-one commented 4 years ago

For autofill, which works like in Bitwarden, would an accessibility service for KeePassDX be required, right? Ah okay, now I got the problem. So there is no bug this would be a huge feature request, my fault.

ghost commented 4 years ago

I had noticed this issue recently, but I am sure this issue did not exist a few weeks ago. Perhaps this issue is related to Android 11 because this issue is reproduced even if downgrading Firefox or KeePassDX.

J-Jamet commented 4 years ago

Indeed, I also think that it comes from Android 11. Because I have just retested on Android 10 and I have no problem with firefox. I don't have a device with Android 11 yet so I'll have to get one.

J-Jamet commented 4 years ago

https://developer.android.com/guide/topics/text/ime-autofill

J-Jamet commented 4 years ago

I just tested on Android 11 with Lightning and have no issues so the problem is with firefox. ~I can't do anything on my side.~

J-Jamet commented 4 years ago

But you're right, Bitwarden managed to display its popup with the autofill, there must be a trick.

J-Jamet commented 4 years ago

OK, I think I found it. It seems that the new version of firefox returns the webDomain several times and the first time it is empty. I will try to improve the algorithm to solve this problem. Sorry for those hasty conclusions.

101lols commented 1 year ago

Iam still having the same issue on version 3.5.0Beta02, android 13, & firefox 108.1.0.

J-Jamet commented 1 year ago

https://github.com/Kunzisoft/KeePassDX/issues/1465

https://github.com/Kunzisoft/KeePassDX/wiki/Magikeyboard Wiki : Warning: if you use the button in a web browser, it will be the name of the browser package that will be used and not the URL of the page. For the URL, use method B.