search

Kunzisoft / KeePassDX

Lightweight vault and password manager for Android, KeePassDX allows editing encrypted data in a single file in KeePass format and fill in the forms in a secure way.
https://www.keepassdx.com/
GNU General Public License v3.0
4.79k stars 276 forks source link

Choose the TOTP format to be generated #886

Open toymil opened 3 years ago

toymil commented 3 years ago

After reading some old issues, I realized the situation is more complex, so here is my revision:

Is your feature request related to a problem? Please describe. In official KeePass using the KeeTrayTOTP plugin, the totp information is stored in two separate fields (seed and specifications), and the two field names can be customized in the plugin settings. Keepass2Android use this format and provide the same settings to set custom field names as to KeeTrayTOTP.

KeePassXC and KeePassDX do not recognize the KeeTrayTOTP format, so as other implementations that do support two fields format but lack the support of field name customization.

Describe the solution you'd like Provide field name customization in the settings, and read like KeeTrayTOTP when those fields are detected?
Plus some settings to let the user choose what format to use by default when adding totp information.

droidmonkey commented 3 years ago

KeePassXC is not going to be implementing this.

J-Jamet commented 3 years ago

This format is already implemented. A bug was fixed in development because the settings were not correctly formatted (will be release in 2.9.13).

I think you are confused because the TOTP form of KeePassDX generates an otp field identical to the one of KeePassXC (otpauth link).

I'm not going to generate a new format automatically by this form (at least not a plugin format), if you want to modify the parameters related to this special format, do it manually.

Especially since now there is another native format in KeePass2 since 2.47, which makes this plugin obsolete.

J-Jamet commented 3 years ago

I will reconsider the question of choosing the form generation format when I have time. But I have other more urgent matters to deal with at the moment.

toymil commented 3 years ago

Thanks for the information about KP native format.

KeePassXC seems to use the Key-Uri format, aren’t KeePassDX using this format too? (with the same field name otp)

J-Jamet commented 3 years ago

Yes, the otp by URI (otpauth) format is recognized and the one generated by the form in KeePassDX.

toymil commented 3 years ago

I understand that although DX use key-uri format by default, it does support the two field format used by Tray TOTP. But the original problem I tried to say is that, those two field names can be customized; and once customized it won’t be recognized by other clients unless they provide the ability to let the user specify what field names to look for.

Anyway, this use case of customized field name is probably rare, I have already taken some time to migrate my DB to a more standard format 😂

J-Jamet commented 3 years ago

I understand the problem very well, that's why I recommend that you create custom fields manually if you want another format instead of using KeePassDX's OTP generator form.

I can improve the concept by providing the same output format as the input if using the form. It can be done for one entry but then we have to generalize it to the whole database to make it consistent.

Like I said, I don't have time to do this functionality right now.