Kunzisoft / KeePassDX

Lightweight vault and password manager for Android, KeePassDX allows editing encrypted data in a single file in KeePass format and fill in the forms in a secure way.
https://www.keepassdx.com/
GNU General Public License v3.0
4.35k stars 262 forks source link

The "The database file has been modified outside the app" dialog is non-actionable #899

Open da2x opened 3 years ago

da2x commented 3 years ago

To Reproduce

  1. Open and unlock your password database in the app
  2. Modify the database outside the app while keeping it unlocked in the app
  3. Add a new entry in KeePassDX

Expected behavior A dialog pops up telling me that the database file has changed outside the app. It gives me some options, but the only button is "OK". The dialog should have two buttons "Reload database" and "Ignore (Overwrite)", and a checkbox "Remember my choice/always reload".

Ideally, there shouldn't even be a dialog. For example, KeePassXC on desktop always pulls before pushing changes (reads/reloads the database before writing any change). This pattern reduces the chance of overwriting data and conflicts.

KeePass Database

KeePassDX (please complete the following information):

Android (please complete the following information):

J-Jamet commented 3 years ago

What you describe is not a bug, you just want a change in the user interface to behave differently from the current feature.

Ideally, there shouldn't even be a dialog. For example, KeePassXC on desktop always pulls before pushing changes (reads/reloads the database before writing any change). This pattern reduces the chance of overwriting data and conflicts.

This is the data merge : https://github.com/Kunzisoft/KeePassDX/issues/840

J-Jamet commented 2 years ago

Is the current data merge functionality working for you? The dialog box is just an information, now the merge button is much more accessible and is in front of the reload button.