search

Kunzisoft / KeePassDX

Lightweight vault and password manager for Android, KeePassDX allows editing encrypted data in a single file in KeePass format and fill in the forms in a secure way.
https://www.keepassdx.com/
GNU General Public License v3.0
4.58k stars 270 forks source link

Support yubikey challenge response #8

Closed piratenpanda closed 1 year ago

piratenpanda commented 6 years ago

Would be nice if the app would support challenge response via the yubichallenge app

super9mega commented 1 year ago

Hey! just tested it and everything seems to load, no crashing, but then it tells me that it could not read credentials. not sure what the issue is but I can get a log here in a minuite

macearl commented 1 year ago

The new version works fine for me as well, tried unlocking the database a couple of times no problems or crashes so far.

I assume the key driver will also be added to fdroid once it reaches a stable version?

super9mega commented 1 year ago

oops, Messed up, did not notice we were using KeepassXC format rather than a sperate database.xml format, which is what keepass normal uses. Everything seems to be working NFC and USB.

J-Jamet commented 1 year ago

I assume the key driver will also be added to fdroid once it reaches a stable version?

Indeed

wandering-tales commented 1 year ago

The new 0.1.7 version definitely solved all my crashing issues. Amazing job!

moya2162 commented 1 year ago

I noticed the following issue when trying to open database using magikeyboard:

  1. Use Magikeyboard to launch keepassdx.
  2. Select database.
  3. Type password. Yubikey challenge-response already selected as option.
  4. Select Open.
  5. Get popup about entering challenge-response, not the key driver app. Scan yubikey but fails. Screenshot_20221230-135839_KeePassDX_1
  6. Re-enter password and select open.
  7. Key driver app properly asks for yubikey
  8. Database opens.

Using keepassdx 3.5 beta 01 and key driver 0.1.7.

dave0003 commented 1 year ago

I installed KeePassDX and Key Driver to try with my Yubikey 4. It is working, though I noticed it works better if I wait until Key Driver prompts for the yubikey, to plug the yubikey in. Then after plugging it in, it asks for permissions, and it works. If I try to open the database with the yubikey already plugged in, it fails to open the first time, then asks for permissions, and works the second time.

KeePassDX 3.5.0 Beta01 from F-Droid and Key Driver 0.1.7 from Play Store.

J-Jamet commented 1 year ago

Thx @moya2162 & @dave0003 for your feedback, it's very helpful in identifying and solving problems. I'll add these bugs to the kanban so I can deal with them. https://github.com/Kunzisoft/KeePassDX/projects/43

leaumar commented 1 year ago

Just wanna add my (positive) experience giving kpdx beta and keydriver a try. I got a yubikey just this week, to try the experience myself and figure out how well I can use it for what things. Compared to webauthn under windows and the different official yubi management apps, making a yubikey-locked db (usb+touch) under keepassxc and then opening it on my phone with nfc has worked without a single surprise or error. Very nice, definitely helps make me feel like I could open up to relying on these gadgets soon without worrying much about support issues. Thank you for the great work, buying keepro as we speak 👍

J-Jamet commented 1 year ago

@moya2162 The problem is normally fixed in version 2.5.0beta03, there is a better management of asynchronous events. There is also database merge management using Yubikey as well as autofill management. I didn't see any bug with this new build. If it's OK, I'll switch to stable in a week. @dave0003 Your issue is directly related to the driver app which is rewritten in a more modern way (The problem is decoupled from the KeePassDX app) @leaumar Thank you, it is really appreciated.

moya2162 commented 1 year ago

@J-Jamet So i installed 3.5b3 and tried to unlock my database and it appears the prompting of the key driver works every time, but scanning (nfc) of my yubikey fails every time. I scan (nfc) my yubikey but the key driver doesn't see it. I get a prompt to open a web link to yubikey's key verification page (standard).

Using an OTG cable the yubikey works, but not ideal.

I did a fresh install, wiped app data and cache, uninstalled 3.5b1 (fdroid) and installed 3.5b3 (git).

EDITL***

Nevermind this post, See post below for explanation!

J-Jamet commented 1 year ago

The problem comes rather from the driver / NFC reception. I did not touch this part and it works on 3 of my NFC phones.

moya2162 commented 1 year ago

False alarm! I have a tasker profile that automatically turns on NFC when keepassdx and key driver are open and turns it off when closed. When i installed the new app it wasn't picked up by tasker so NFC was off when keepassdx was launched. NFC only turned on when key driver was open but at that point it wouldn't work. NFC needs to be on when in keepassdx. If not it fails.

All worked on my end now!

J-Jamet commented 1 year ago

Stable release 3.5.0 done, the driver remains in beta version until finalization but remains functional. Enjoy

52fitz commented 1 year ago

Nice. Many thanks.

nimser commented 1 year ago

After clicking "OPEN" I get the prompt to swipe the NFC device, then I'm asked to select a default app. I see only web browser, not the keyDriver app. What am I missing?

I installed 0.1.7

J-Jamet commented 1 year ago

Duplicate https://github.com/Kunzisoft/KeePassDX/issues/1504