[2.9.14_Beta] Save a database with binary corrupts the database

Kunzisoft / KeePassDX

Lightweight vault and password manager for Android, KeePassDX allows editing encrypted data in a single file in KeePass format and fill in the forms in a secure way.

https://www.keepassdx.com/

GNU General Public License v3.0

4.32k stars 261 forks source link

[2.9.14_Beta] Save a database with binary corrupts the database #928

Closed J-Jamet closed 3 years ago

J-Jamet commented 3 years ago

Describe the bug After fixing issue #926, corruptions may occur when adding binary files.

To Reproduce Adding a binary to an empty database seems to corrupt the database.

Contains attachment: Yes The problem is present only on v4 databases

KeePassDX (please complete the following information):

Version: 2.9.14_Beta

J-Jamet commented 3 years ago

Fixed, problem comes from BinaryData refactoring : https://github.com/Kunzisoft/KeePassDX/commit/ab268498b6738eb9f32bf0b4b5495a88a9f1b211

A parallel branch has been created to be deployed on the store and prevent corruption : release/2.9.14_test_binary code 64