Kureev / react-native-blur

React Native Blur component
MIT License
3.76k stars 556 forks source link

Update BlurViewManagerImpl.java #512

Closed Gregoirevda closed 1 year ago

Gregoirevda commented 1 year ago

Only use optimised if hardware acceleration isn't disabled

Gregoirevda commented 1 year ago

fixes #489

AdvMaple commented 1 year ago

I tried this, and it work

kesha-antonov commented 1 year ago

Need this fix

ndekross commented 1 year ago

When is this going to be published?

bastianspirek commented 1 year ago

Waiting for this as well.

tslater commented 1 year ago

How can we get this thing merged? @Kureev Basically this library crashes a lot of android phones without this...

antoinebrtd commented 1 year ago

@Kureev can we merge this as well pls?

vinitraj10 commented 1 year ago

As a temporary solution until this gets merged, if you all still struggling and want this to be used as a package, i have created a repository and put the bundle there, since we had the same issue and as we work closely with CI/CD, applying patch locally was not a good solution for us, as CI scripts need to be updated to discard the changes every time yarn or npm install done.

Instead i just moved the patch bundle into a github fork and started using it in our package.json which was much more cleaner solution as it doesn't touch .gitignore to ignore few patch files and CI is also happy.

just forking to git repo and using url might not work as the package is not compiled while forked so you need to bundle it and place in fork if you want to use it that way

You can use our bundle by using the following command

> yarn add 'vinitraj10/react-native-blur'

or

npm install 'vinitraj10/react-native-blur'
mlaythe commented 1 year ago

any update on when this will be merged?

jspizziri commented 1 year ago

@Titozzz any chance you could look at this? If not are there other maintainers that could be worked with? Or is this package looking for new maintainers?

Titozzz commented 1 year ago

Added a Todo for Tuesday 🙏