search

Kureev / react-native-blur

React Native Blur component
MIT License
3.74k stars 555 forks source link

feat: android blurview library updated #598

Open dopplerDistortion opened 9 months ago

dopplerDistortion commented 9 months ago

Android BlurView library updated with @stemyke's PR https://github.com/Dimezis/BlurView/pull/201

closes #511

stemyke commented 9 months ago

@dopplerDistortion Hey! Awesome that you started a PR, but its not gonna help on the problem by itself. Here is a patch file I created which has a lot of tweaks to bring the look of the iOS and Android versions closer to each other:

@react-native-community+blur+4.3.2.patch

Can you please apply this to your repository somehow?

stemyke commented 9 months ago

I hope when its done, then @Kureev can help us merge it.

dopplerDistortion commented 9 months ago

@stemyke Hey! I tried but, patch file has some auto generated changes and files inside. If you can send the diff your changes instead of patch file it would be much more useful.

stemyke commented 9 months ago

Sure! Here are all the files from the package including the modified ones:

blur.zip

dopplerDistortion commented 9 months ago

@stemyke Just pushed it to the PR. But I couldn't understand why BlurViewManagerImpl.java inside main folder and BlurViewManager.java file inside oldarch folder is deleted. Could you give us a explanation for that ? After that @Kureev can review it properly I'm sure.

stemyke commented 9 months ago

@dopplerDistortion Oh no! You are right, I did not understand why was the BlurViewManager separated from its implementation, now I get it, because it was based on the RN architecture and it is different. Can you please restore BlurViewManager to its original place, but only with the tweaked and removed properties? And please do that also in the newarch if you can. I feel like the BlurViewManagerImpl is still unnecessary because now I am doing the necessary calculations inside the BlurView.

Edit: I only use oldarch in my project and I did the changes directly in node_modules and thats why I did not notice it.

dopplerDistortion commented 9 months ago

@stemyke it is restored to original place. But I don't have enough understanding about new arch. Maybe you can send their changes after checking it.