Kureev / react-native-blur

React Native Blur component
MIT License
3.74k stars 555 forks source link

Do not crash when the main activity is unavailable #601

Open trne opened 8 months ago

trne commented 8 months ago

Note

This is a dupe of this other PR, which is ready to merge but has merge conflicts that I can't solve because is not on my fork. so since I need this fix ASAP, I'm pushing the same fix on an up to date branch with no conflicts.

Summary

The React Native application context has a method for obtaining the current Android activity, but this sometimes returns null. We believe this happens due to a race condition between the JavaScript engine and the native code, but we aren't completely sure. What we do know is that this situation happens in the wild, since it shows up in our Bugsnag reports.

The fix is to leave the BlurView native component uninitialized in these cases. This prevents it from rendering anything, but that's preferable to crashing the whole app.

Screen Shot

Test Plan

Since we don't have a reproduction case for the crash, we intend to deploy these changes in the next release of our App and then see if our Bugsnag reports are any cleaner.

Compatibility

OS Implemented
iOS
Android

Checklist

trne commented 8 months ago

@Titozzz one for you I guess.

solitarysp commented 3 months ago

I got the same error. Have we solved it?