search

Kureev / react-native-blur

React Native Blur component
MIT License
3.75k stars 555 forks source link

Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated. #622

Open sonodima opened 1 month ago

sonodima commented 1 month ago

Starting from version 8, Gradle requires the namespace to be specified in the build.gradle file, and not AndroidManifest.xml.

Here is a build I have done using Gradle 8.1.1:

> Task :react-native-community_blur:processDebugManifest FAILED

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':react-native-community_blur:processDebugManifest'.
> A failure occurred while executing com.android.build.gradle.tasks.ProcessLibraryManifest$ProcessLibWorkAction
   > Incorrect package="com.reactnativecommunity.blurview" found in source AndroidManifest.xml: /redacted/node_modules/@react-native-community/blur/android/src/main/AndroidManifest.xml.
     Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported.
     Recommendation: remove package="com.reactnativecommunity.blurview" from the source AndroidManifest.xml: /redacted/node_modules/@react-native-community/blur/android/src/main/AndroidManifest.xml.
Kxkee commented 1 month ago

got the same problem, any update ?

sonodima commented 1 month ago

Unfortunately not yet, I postponed the Gradle 8 update for now.

Tbh the fix would be very simple. If the author won't work on it, I'll see if I can create a MR once I can dedicate it some time :/