search

Kureev / react-native-blur

React Native Blur component
MIT License
3.74k stars 555 forks source link

[iOS] Animations #95

Open wokalski opened 7 years ago

wokalski commented 7 years ago

Follow up to the discussion in #62.

Instead of using imperative API we can expose and with animation parameters required. What do you think?

@Kureev I'm not sure what you mean here. Would you like more options in the imperative API or pass somehow the transition to props? (not sure how)

wokalski commented 7 years ago

@Kureev ping

Kureev commented 7 years ago

You can use LayoutAnimation and/or Animated to achieve this effect.

P.S. Sorry for the late response.

wokalski commented 7 years ago

Not really. Native blur animation kind of blurs in/out. It's not a fade transition.

Kureev commented 7 years ago

Does it look different? I've made my conclusion based on the feedback in this issue: https://github.com/react-native-community/react-native-blur/issues/52

Kureev commented 7 years ago

maybe @shahen94 or @aforty can give more insights / provide an example

wokalski commented 7 years ago

Yes, it is different. Think of it as going from blur with radius 0 to x by increasing blur radius vs fading in the blur view. I can provide you with an example if you want.

Kureev commented 7 years ago

Yeah, I got what you mean. It sounds like a nice improvement, but I'm not sure if I have enough time to pick it up. Although, I'll try to do my best reviewing a PR implementing this feature.

I'll re-open it for now

fukemy commented 1 year ago

any sample code?