Kureev / react-native-side-menu

Side menu component for React Native
MIT License
2.21k stars 435 forks source link

Issue of having ScrollView as content #26

Closed alinz closed 9 years ago

alinz commented 9 years ago

If you have a ScrollView as content of SlideMenu, toleranceX and toleranceY are not helping with the current implementation. After digging, I realize that this line, return x != this.props.toleranceX && y < this.props.toleranceY; needs to be changed to return x > this.props.toleranceX && y < this.props.toleranceY; in order for them to work properly.

Does it make sense?

Kureev commented 9 years ago

Seems so