search

Kureev / react-native-side-menu

Side menu component for React Native
MIT License
2.21k stars 434 forks source link

Warnings #399

Open acavrbaski opened 4 years ago

acavrbaski commented 4 years ago

Can you PLEASE update react-native-side-menu to remove next warnings:

  1. Animated: "useNativeDriver" was not specified. This is required option and must be set to 'true' or 'false' By documentation, it should be used like this: Animated.timing(this.state.animatedValue, { toValue: 1, duration: 500, useNativeDriver: true, // <-- Add this }).start();

  2. componentWillReceiveProps has been renamed, and is not recomended for use.

  3. componentWillMount has been renamed, and is not recomended for use.

This will be problem is future and your plugin is very good. Would be shame to have problems in near future. Thanks a lot in advance.

crobinson42 commented 4 years ago

@acavrbaski did you open a PR?

jcarioti commented 4 years ago

@acavrbaski did you open a PR?

I think these PRs have already been closed. All that needs to happen is an NPM release.

Nemferno commented 4 years ago

If there are no responses, better if there is an established set of maintainers for this repo to continue the work, to clean up the issues, and to push a NPM release.

jcarioti commented 4 years ago

@Kureev Who are the active maintainers of this repo? We just need someone to create a new release for NPM and it's been radio silent since we last heard from you in March. Can we please add at least one maintainer that checks this project, even if it's just once a month or so?

sbrighiu commented 4 years ago

https://github.com/react-native-community/react-native-side-menu/issues/387

alessiocancian commented 4 years ago

https://github.com/react-native-community/react-native-side-menu/issues/398#issuecomment-645882904