Kurento / bugtracker

[ARCHIVED] Contents migrated to monorepo: https://github.com/Kurento/kurento
46 stars 10 forks source link

Fixme: Session should be removed #552

Closed fabfreitas closed 3 years ago

fabfreitas commented 3 years ago

I am getting this error indefinitely. I already set the Garbage Collector do 60 seconds, but the old sessions still keep.

In the WebSocketTransport.cpp at the line 348 we have this:

try {
        processor->keepAliveSession (c);<br/>
} catch (KurentoException &e) {
        if (e.getCode() == INVALID_SESSION) {
          GST_FIXME ("Session should be removed: %s", c.c_str() );
          // TODO: Remove session
        } else {
          throw e;
        }
}

So, this TODO won't be fixed?

Could this code resolve this TODO?

try {
        processor->keepAliveSession (c);<br/>
} catch (KurentoException &e) {
        if (e.getCode() == INVALID_SESSION) {
              closeHandler(c);
        } else {
             throw e;
        }
}
github-actions[bot] commented 3 years ago

Hello @fslayer! :wave: we're sorry you found a bug... so first of all, thank you very much for reporting it.

However, your report doesn't follow the issue template, so it is being automatically closed. We are really sorry for that, but we need all reports to follow the template, or else it won't be possible to understand and help with all issues.

Please, create a new issue following the template, or reopen this same issue to edit and provide all required information.