search

Kurinku-Studios / FNF-Forward-Launcher

A mod launcher for FNF: Forward!
GNU General Public License v3.0
11 stars 9 forks source link

A mod library. #38

Closed xyaxical closed 3 years ago

xyaxical commented 3 years ago

Aka a store like library anyone can submit mods to that then go under review and get into the library.

ColonelKai commented 3 years ago

We are planning on opening the Launcher to public mods in version 1.2.

How the mods will be submitted and then accepted is not decided upon yet, however.

mosemister commented 3 years ago

The main issue to opening it to the public currently is there is a small amount of things that the developer of the mod needs to ensure, the launcher currently does not have the checks in place to prevent a mod from being destructive.

I personally would say it will be a later version then 1.2

ColonelKai commented 3 years ago

We could still manually check some mods, that's what i mean mostly, not an automated system.

mosemister commented 3 years ago

Ok, so lets say you add a 3rd party mod using a github url of the latest. They then release a update to the mod which is no longer a zip file.

In the current systems state, the system would attempt to download it, github would send its 404 page, resulting in the system downloading the 404 page and then extracting that 404 page as a zip. The last step obviously cannot happen as a html 404 page is not a zip file resulting in a crash and a pissed off user, resulting in the blame being the launcher (because .... Well it pretty much is)

How are you going to manually check that its not a zip anymore?

Download every 3rd party mod and check to see if its valid?

With the automatic checks, im not saying use A.I to do a virus scan on it or have a automatic approval system. Im saying have automatic validation checks to make sure that what the user is downloading is ...well .... Safe

ColonelKai commented 3 years ago

fair enough