KurtBestor / Hitomi-Downloader

:cake: Desktop utility to download images/videos/music/text from various websites, and more.
21.68k stars 2.01k forks source link

sankakucomplex - no download speed + multiple errors on saving + task info #6943

Open 4Sol opened 6 months ago

4Sol commented 6 months ago

Hello After an update I have no speed downloading from the site It counts all the images, but when download starts it stuck at 0 kb/s

Also when I go task info I get this line: image

Same with technical preview

Also when I go save and quit I get this error now: image

image

KurtBestor commented 6 months ago

Are you using any custom plugins?

4Sol commented 6 months ago

Yes, https://github.com/rickmiron/variado/blob/main/sankaku_downloader.py

Here is the task info on my last try without loging in (probably not admin launched): https://pastebin.com/CNGuaw55

When I load cookies (or run it as an admin not sure which works) but it starts to count images, but speed is at 0 kb/s forever

It was working yesterday, not sure what's the matter

rickmiron commented 6 months ago

I have the same problem, but it is with this new version 4.1, the previous version does work. I will check where the conflict may be, for now use the previous version 4.0

KurtBestor commented 6 months ago

Oh, I didn't take the case when the URL is None into account, I'll fix it in the next version. If you modify None to '' in the following part of the script, it should work in v4.1 as well: https://github.com/rickmiron/variado/blob/d49efcde8a0b326026587fcb2bb024a2c6738b20/sankaku_downloader.py#L78

rickmiron commented 6 months ago

I also came to that conclusion, but I have not carried out many tests to verify that it will not cause problems since precisely that variable works as a 'referer' and in sankaku the files are downloaded more safely if they do not have a 'referer'

rickmiron commented 6 months ago

kurtBestor Why when a png file is downloaded in self.single=True mode ffmpeg is activated , creates a jpg copy and then that copy is deleted, but it does not happen when it is jpg

rickmiron commented 6 months ago

4sol, Download the plugin again, it's already fixed

4Sol commented 6 months ago

4sol, Download the plugin again, it's already fixed

I tried new version of the plugin. It did count the images, but the download speed for me is still at 0 KB/s Running as admin with login sankaku cookies

Maybe I'm blocked on sankaku or something? Don't know how to check it.

Pressing info still send me this error: image And on exit from hitomi: image

4Sol commented 6 months ago

A small update.

I tried again with both plugins and they are working now. Don't know what happened :D 1 sankaku_downloader 2 sankaku_downloaderJ

I feel like when I deleted an old plugin and installed the new it still was reading the old one? But once I uploaded a plugin with a "J" different filename maybe it cleared hitomi memory or smth

btw what is the difference between these 2 versions, plugin with "J" and without?

rickmiron commented 6 months ago

sankaku_downloader.py: searches by analyzing all the content that will be downloaded sankaku_downloaderJ.py: search using api, it is experimental and faster