search

KurtCode / PDFKitten

A framework for extracting data from PDFs in iOS
MIT License
391 stars 113 forks source link

Remove the stringDetector delegate after scanning #69

Closed hrakotobe closed 11 years ago

hrakotobe commented 11 years ago

It's a tiny memory related fix, I saw this when trying to integrate this library with another PDF library. Hope it helps.

KurtCode commented 11 years ago

Thanks, but why did you remove the release of selections?

hrakotobe commented 11 years ago

Hello

I removed it because it was released twice (it's already released on the second line of the dealloc, and when I run it the second release was just done against nil)

On Mon, Apr 29, 2013 at 10:24 AM, Marcus Hedenström < notifications@github.com> wrote:

Thanks, but why did you remove the release of selections?

— Reply to this email directly or view it on GitHubhttps://github.com/KurtCode/PDFKitten/pull/69#issuecomment-17154791 .

KurtCode commented 11 years ago

I see.

On Mon, Apr 29, 2013 at 10:45 AM, H. Rakotobe notifications@github.comwrote:

Hello

I removed it because it was released twice (it's already released on the second line of the dealloc, and when I run it the second release was just done against nil)

On Mon, Apr 29, 2013 at 10:24 AM, Marcus Hedenström < notifications@github.com> wrote:

Thanks, but why did you remove the release of selections?

— Reply to this email directly or view it on GitHub< https://github.com/KurtCode/PDFKitten/pull/69#issuecomment-17154791> .

— Reply to this email directly or view it on GitHubhttps://github.com/KurtCode/PDFKitten/pull/69#issuecomment-17155560 .