search

KurtE / Arduino_Phoenix_Parts

Lynxmotion Phoenix Program for Arduino split into libraries
252 stars 98 forks source link

Github actions, Maestro servo driver support, PS3 controller with ESP32 and AliExpress hexapod config #5

Closed klimbot closed 4 years ago

klimbot commented 4 years ago

CI

Other

KurtE commented 4 years ago

Hi, @klimbot It may take me a little time to review.

Thanks for the contributions

klimbot commented 4 years ago

Hi, @klimbot It may take me a little time to review.

Thanks for the contributions

All good, after taking some time I think I should probably close this PR and start a WIP PR so maybe don't look too closely just yet

KurtE commented 4 years ago

Note: Often times like this,

What I do, is to not update the Master branch, but instead have some other branch that all of the work goes into. And when every one is happy, it then gets a final PR into the master branch.

This is for example how I work with Robotis on projects like OpenCM , OpenCR, Dynamixel2Arduino… They will have a branch often named Dev, which they do all of their new stuff with. I will be enlisted into their project and at times will test with/use the master (released version) and other times I will use their DEV branch. Any fixes I make are PR’d to their DEV branch.

From: klimbot notifications@github.com Sent: Thursday, December 12, 2019 6:39 PM To: KurtE/Arduino_Phoenix_Parts Arduino_Phoenix_Parts@noreply.github.com Cc: KurtE kurte@rockisland.com; Comment comment@noreply.github.com Subject: Re: [KurtE/Arduino_Phoenix_Parts] Github actions, Maestro servo driver support, PS3 controller with ESP32 and AliExpress hexapod config (#5)

Hi, @klimbot https://github.com/klimbot It may take me a little time to review.

Thanks for the contributions

All good, after taking some time I think I should probably close this PR and start a WIP PR so maybe don't look too closely just yet

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KurtE/Arduino_Phoenix_Parts/pull/5?email_source=notifications&email_token=AAL4MQGTBLA2CZ4YBD3UOGLQYLYU5A5CNFSM4JZ3HFYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGYWY5Y#issuecomment-565275767 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAL4MQC3LEJHRTTPKHGSLFTQYLYU5ANCNFSM4JZ3HFYA .

klimbot commented 4 years ago

Sounds good @KurtE

I'll cancel this PR and start a new one when you have created a develop branch

KurtE commented 4 years ago

I pushed up a new branch… Which currently is in sync with master.

Note: these days I do very little up on this project. With the Phoenix like code, when I am working on it, I am doing it mostly in other projects which

Are more specific to non-rc servos, in particular Dynamixel by Robotis. Also with using Robotis libraries and/or working with Teensy processors. i.e. I do very little these days with AVR based boards. I do from time to time still checkout the runnings on the Trossen boards (Arbotix, but that is not often)…

From: klimbot notifications@github.com Sent: Friday, December 13, 2019 2:22 AM To: KurtE/Arduino_Phoenix_Parts Arduino_Phoenix_Parts@noreply.github.com Cc: KurtE kurte@rockisland.com; Mention mention@noreply.github.com Subject: Re: [KurtE/Arduino_Phoenix_Parts] Github actions, Maestro servo driver support, PS3 controller with ESP32 and AliExpress hexapod config (#5)

Sounds good @KurtE https://github.com/KurtE

I'll cancel this PR and start a new one when you have created a develop branch

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KurtE/Arduino_Phoenix_Parts/pull/5?email_source=notifications&email_token=AAL4MQAJFIBXI6OZUYD56H3QYNO6HA5CNFSM4JZ3HFYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGZR3LI#issuecomment-565386669 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAL4MQEDBGJMFA2V3T54DMTQYNO6HANCNFSM4JZ3HFYA .

klimbot commented 4 years ago

I did notice you last few commits were for teensy board stuff @KurtE. I've been working mostly with ESP8266/ESP32 the last few years, one of the best things was being able to pair the ESP32 with a PS3 controller. Much easier than the PS2 controller.

I took a quick look at getting it going in the CI pipeline but couldn't immediately see a way to do it via the command line, I only saw a GUI installer. Do you have any ideas/links about how it could be done in Linux from the command line?