KusionStack / konfig

Shared repository of application models and components, and CI suite for GitOps workflows
Apache License 2.0
27 stars 32 forks source link

fix: backend service name in http-echo #93

Closed jakezhu9 closed 1 year ago

jakezhu9 commented 1 year ago

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

fix #92

2. What is the scope of this PR (e.g. component or file name):

appops/http-echo/base/base.k

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
jakezhu9 commented 1 year ago

Hi! I've noticed that there is an error in CI, and I've already investigated it. It looks like the error may be caused by something else. I'll create an issue for it later.

As for this PR, it's just a small change, and you can easily verify it manually.

If you have any other idea, just tell me!

Peefy commented 1 year ago

Hi! I've noticed that there is an error in CI, and I've already investigated it. It looks like the error may be caused by something else. I'll create an issue for it later.

As for this PR, it's just a small change, and you can easily verify it manually.

If you have any other idea, just tell me!

Thank you for your contribution. The CI error was caused by other reasons (inappropriate testing script), and I will merge this PR. Thank you again.