search

KusionStack / kusion

Declarative Intent Driven Platform Orchestrator for Internal Developer Platform (IDP).
https://kusionstack.io
Apache License 2.0
874 stars 78 forks source link

Feat: Enable skip delete import tf resource when destroy #1200

Closed hoangndst closed 2 months ago

hoangndst commented 3 months ago

What would you like to be added?

Option skip delete imported tf resource when destroying release.

Why is this needed?

When the imported tf resource is still used by another release, we need to retain it so that the release using that resource can function properly.

SparkYuan commented 3 months ago

@hoangndst Thank you for your feedback! This is indeed a valuable suggestion! Are you interested in implementing this feature?

hoangndst commented 3 months ago

About this feature. I plan to add an IgnoreExternal field to the model Operator so from there the user can pass the command e.g. kusion destroy --ignore-external to the lower part to handle. cc @SparkYuan @liu-hm19 looking for your view of this!

SparkYuan commented 2 months ago

@hoangndst Imported resources should not be deleted by default. Currently, we don't need to add a new flag to ignore imported resources, we should change the default behavior to not to delete.

hoangndst commented 2 months ago

That much better