search

Kvalifik / how-we-work

A handbook for software development at Kvalifik
0 stars 0 forks source link

Run linting and/or tests as pre-commit / pre-push hooks #152

Closed forecast[bot] closed 9 months ago

forecast[bot] commented 2 years ago

We could use husky, lint-staged, and organize-imports-cli to make sure no unlinted code gets past a commit.

And for the tests I imagine it would be annoying to run it on every push so maybe some kind of integration with kvalifik-cli? We could run tests as a pre command before `kvalifik-cli ready-for-review` so that it's more likely that the CI pipeline will not fail after push

I'm running a similar setup in the tauri, svelte ramen to birru so I could easily port that into our templates.

forecast[bot] commented 2 years ago

I'm a fan of the idea - but will this give us any headaches in regards to our Docker setup? (especially fan of doing it pre-push, since I often do many many small commits)

forecast[bot] commented 2 years ago

Rasmus Hag Løvstad I don't think this should have anything to do with Docker. It would only influence our git flow.