search

KvanTTT / CSharp-Minifier

Library for C# code minification based on NRefactory. That is lib for spaces, line breaks, comments removing, reduction of identifiers name length and so on in C# code.
Apache License 2.0
41 stars 21 forks source link

inherited protected methods not recognized correctly. #36

Closed theCalcaholic closed 7 years ago

theCalcaholic commented 7 years ago

"Compress members" breaks inheritance with protected members (parent class protected members are being renamed, child class protected (overriding) members arent).

class Parent {
  protected virtual var someMethod() {
  }
}
class Child : Parent {
  protected override var someMethod {
  }
}

results in: class b{protected virtual var a(){}}class c:b{protected override var someMethod{}}

KvanTTT commented 7 years ago

This is a known issue, see also https://github.com/KvanTTT/CSharp-Minifier/issues/33 and https://github.com/KvanTTT/CSharp-Minifier/issues/32. Unfortunately I have no idea how it can be resolved with NRefactory. So, I close this issue as a duplicate.

theCalcaholic commented 7 years ago

Ah okay. Still, thanks for the work!