search

Kvoti / redux-rest

Automatically create Redux action constants, action creators, and reducers for your REST API
MIT License
180 stars 11 forks source link

ItemReducer doesn't support retrieve #10

Closed bhoomit closed 8 years ago

bhoomit commented 8 years ago

I don't see an "else if" condition for "action.type === this.actionTypes.retrieve" for retrive actions.

mallison commented 8 years ago

Oh, good point! The action should be available so adding retrieve to the reducer, following the pattern of the other actions, should work ok. (Just noticed the _success, _failure code could probably be pulled out to a function so you don't have to type out the three cases for each action manually).

mallison commented 8 years ago

I've added retrieve to the reducer with some basic tests.

bhoomit commented 8 years ago

@mallison cool, it works. Thanks :)

mallison commented 8 years ago

No problem! On 29 Mar 2016 8:12 a.m., "Bhoomit" notifications@github.com wrote:

@mallison https://github.com/mallison cool, it works. Thanks :)

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Kvoti/redux-rest/issues/10#issuecomment-202749927