search

KwaiVGI / LivePortrait

Bring portraits to life!
https://liveportrait.github.io
Other
13.06k stars 1.39k forks source link

Paste-back not working as intended with --no_flag_stitching #134

Closed Lesteriax closed 4 months ago

Lesteriax commented 4 months ago

I might have understood this wrong but when all 4 options are selected:

using flag: --no_flag_stitching relative motion = true do crop (source) = true paste-back = true do crop (driving video) = true

The results are still cropped even though the expected behavior is to paste back on the original. However, using the same 4 options without using the flag, it pastes back the results correctly.

So either paste-back is not working as intended with the stitching flag, or the 'do crop (source) is not working as intended without using the --no_flag_stitching

cleardusk commented 4 months ago

In a sense, stitching is designed for pasting back. If cropping(source) is disabled, pasting back is meaningless. @Lesteriax

https://github.com/KwaiVGI/LivePortrait/blob/b370d8059c4794ad2afce2db404e2aa5450e098c/src/live_portrait_pipeline.py#L210-L213