Closed shaneroesemann closed 2 years ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit eb29f23
+| ✅ 62 tests passed |+
#| ❔ 34 tests were ignored |#
!| ❗ 9 tests had warnings |!
Merging #242 (eb29f23) into main (ad0364a) will decrease coverage by
0.29%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #242 +/- ##
==========================================
- Coverage 27.61% 27.31% -0.30%
==========================================
Files 45 45
Lines 5334 5334
==========================================
- Hits 1473 1457 -16
- Misses 3861 3877 +16
Flag | Coverage Δ | |
---|---|---|
unittests | 27.31% <ø> (-0.30%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
autometa/binning/unclustered_recruitment.py | 83.15% <0.00%> (-8.70%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ad0364a...eb29f23. Read the comment docs.
happy to make the branch change.
title: Autometa
authors:
- family-names: Kwan
given-names: Jason C.
^^ this needed to be included. At least through the context of validating the .cff with cffconvert. I originally did not have it but the validation required a title and author field in the first indentation. Maybe I can look into validating it on my personal github and/or look into a different validation package (i see there is at least one other).
I can make the changes you suggested, thanks
@chasemc @WiscEvan
OK I made the changes requested. I think I pushed to the dev branch this time. thanks
Looks good, I checked it in another repo and it shows the citation as the v1 manuscript I changed the PR to merge into dev
@WiscEvan I don't get why codecov is picking up on an unchanged file?
@WiscEvan I don't get why codecov is picking up on an unchanged file?
I'm not sure why codecov is picking this up. It has shown some odd behavior in the past 🤷
PR checklist
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).