Open chasemc opened 1 year ago
Hey, I wanna work on this issue can you guide me?
Hello Rajnish, thank you for getting involved. I see you have submitted a pull request (#307), thanks so much! Generally we prefer new changes be pushed to the dev
branch and then synchronize our branches with new releases. This way we can save ourselves from accidentally introducing bugs. It looks like you may have addressed all of the issues, but @chasemc and @ajlail98 may want to weigh in on next steps. Thanks again for your contributions! Feel free to tackle more! 😄
Well, thanks! 😅
Hello Rajnish, thank you for getting involved. I see you have submitted a pull request (#307), thanks so much! Generally we prefer new changes be pushed to the
dev
branch and then synchronize our branches with new releases. This way we can save ourselves from accidentally introducing bugs. It looks like you may have addressed all of the issues, but @chasemc and @ajlail98 may want to weigh in on next steps. Thanks again for your contributions! Feel free to tackle more! 😄
Probably best to wrap https://github.com/KwanLab/Autometa/blob/b1ec370c44e7accfc917aaad1a685133537fd915/autometa/validation/datasets.py#L63-L67 in a non-failing try/except
The amount of data the script downloads is quite large, I would suggest making the suggested change and PR but maybe not testing it on your end
There are some files that don't exist for all of the example datasets which causes the script to fail: