Fix NA issues after Pandas update

KwanLab / Autometa

Autometa: Automated Extraction of Genomes from Shotgun Metagenomes

https://autometa.readthedocs.io

Other

40 stars 15 forks source link

Fix NA issues after Pandas update #361

Closed chasemc closed 3 weeks ago

chasemc commented 4 weeks ago

Sidduppal commented 4 weeks ago

Looks good. Few points:

Please implement the changes for hbscan as well.
Update the version in VERSION and nextflow.config for the new release
Is dev upto date with main? I would do a pull before the merge.

chasemc commented 4 weeks ago

I've spent as much time as I can on this and welcome anyone else to make the changes mentioned above. I already fast forwarded dev onto main

Sidduppal commented 3 weeks ago

In reference to

With this update I'm getting more and better clusters than the unit test data t hat I have access to (we're looking to that in the meantime).

I ran binning (using dbscan) using the dev branch and v2.0.0 and the results are exactly the same. Files are attached for reference. I will do the same changes for hdbscan.

Archive.zip

chasemc commented 3 weeks ago

Fixes #349