Kwasniok / python-nerte

non-euclidean ray tracing engine
2 stars 0 forks source link

fix transformation direction for manifolds #41

Closed Kwasniok closed 3 years ago

Kwasniok commented 3 years ago

The choice of the swirl parameter is currently inconsistent. Make "-a" the flat to swirled transformation and "+a" the inverse transformation.

Let p be a point in space. It is represented by cand s in flat and swirled coordinates respectively. Let f_a(c) = s, then f_a maps the flat angle phi to the swirled alpha = phi - a *r * z.

The original mistake came from confusing active and passive transformation and assumed ~alpha = phi + a *r * z~.

part of: #52