KwiatLab / Quantum-Tomography

A python library to help perform tomography on a quantum state
http://tomography.web.engr.illinois.edu/TomographyDemo.php
MIT License
29 stars 9 forks source link

Calling buildTomoInput fails when passing default values to the optional arguments #34

Closed luyves closed 1 year ago

luyves commented 1 year ago

Hi team.

I noticed I was unable to replicate the simple 2 qubit/4 detector example on the website while on the latest release (1.0.5). A quick look at the code suggested me that it was failing to create the input matrix due to a shape mismatch, happening in the TomoClass.py file.

However, calling stateTomography_Matrix still fails eventually if you do not explicitly provide the efficiencies array (it seems the default value of 0 is not accepted). I suspect there must be an error in the way the default values for these parameters are handled, but since passing them explicitly avoids these issues I would hope it's an easy fix.

smturro2 commented 1 year ago

Thanks for the details. Updates have been made to the dev branch and I'm looking to get this in production soon

smturro2 commented 1 year ago

@luyves This is fixed in v1.0.6