search

Kwpolska / pkgbuilder

An AUR helper (and library) in Python 3.
http://pkgbuilder.rtfd.org/
BSD 3-Clause "New" or "Revised" License
71 stars 12 forks source link

Failed builds go into an infinite loop #1

Closed fosskers closed 12 years ago

fosskers commented 12 years ago

Attempt to build cower and you should see what I mean. Dependency checking passes, but the build script itself is broken. This sends pkgbuilder into an infinite loop of attempting to clone the git repo, downloading the source, attemping to build, and failing.

Kwpolska commented 12 years ago

I don’t see the problem… Both cower and cower-git work for me. Mind putting up the output here?

Kwpolska commented 12 years ago

On another thought, I think I might know what the problem is. I think that all I need is to crash when makepkg fails. I will do this tomorrow, along with a fix of the whole failure behavior, dropping the pointless “Something went wrong.” message and a number and a fancy string that nobody in this universe, including me, understands. Same goes for the pointless message codes, which will be dropped in favor of nicer error messages. Thanks for reporting, but I’d still love to see the output.

fosskers commented 12 years ago

. . . ==> Starting build()... make: Entering directory /home/colin/building/cower/src/cower-6' cc -std=c99 -g -pedantic -Wall -Wextra -pthread -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -DCOWER_VERSION=\"6\" -c -o cower.o cower.c cc -o cower cower.o -lcurl -lalpm -lyajl -larchive -lcrypto -pthread -Wl,-O1,--sort-common,--as-needed,-z,relro pod2man --section=1 --center="Cower Manual" --name="COWER" --release="cower 6" README.pod > cower.1 /bin/sh: pod2man: command not found make: *** [cower.1] Error 127 make: Leaving directory/home/colin/building/cower/src/cower-6' ==> ERROR: A failure occurred in build(). Aborting... ==> ERROR: [ERR3402] Something went wrong. EC=2 EM=makepkg

I'm attempting this on owl-git now, which has cower as a dependency. The behaviour seems to be changing... some times it enters the loop and sometimes it doesn't. Building cower on its own actually succeeded once, but I'm not sure why.

fosskers commented 12 years ago

Turns out the reason for the failing is my shell's fault, but the fact remains that pkgbuilder still needs to deal with failures when they do eventually happen.

Kwpolska commented 12 years ago

Thanks! I will push up a fixed version in a hour or two, I just need to do some testing and stuff.

fosskers commented 12 years ago

My pleasure! I've been doing research into the different AUR helpers lately and I noticed yours was being actively developed, so I gave it a try!

Kwpolska commented 12 years ago

I hope you will find it awesome, especially with the pb wrapper for pacman!

Kwpolska commented 12 years ago

@fosskers, Would you please mind testing it?

fosskers commented 12 years ago

Not at all. If you help test mine too, that is!

If pkgbuilder can build xmobar-git (a package with tons of AUR build deps), then it should be fine. I'll try it right now.