Closed nipsn closed 7 months ago
@cmccarthy1 @rianoc-kx Please review our contributions and feel free to give any kind of feedback. Thanks in advance.
Thanks @nipsn we'll aim to review before the end of the week and get back to you with any feedback/updates! Thanks for the contribution
Hi @cmccarthy1 I just came back after my leave, please let me a few days to take a look at these changes before handing them back to you, just to check our progress. Thanks!
No issues @neutropolis I've added a couple of small comments to ponder but will hold off digging deeper until after you've reviewed further
Hi @cmccarthy1 sorry for the delay, it took us longer than expected to review the code. In essence, we've decided to remove round
from this contribution and put it off for the near future, since we've started to work in other functions from the pandas api that we hope to share with you in the near future. Beyond that, all methods and tests have been polished and we think the new version is simpler and more elegant. Unfortunately, we could see that there was some kind of problem while cherry picking commits, which made it very hard to review the changes at the test file. Therefore, we are about to create a new PR (https://github.com/KxSystems/pykx/pull/16) and close the present one.
Feature
What does this change introduce?
An implementation of the
skew
function: https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.skew.html#pandas.DataFrame.skewAn implementation of the
add_prefix
andadd_suffix
function: https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.add_prefix.html https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.add_suffix.htmlObservations:
An implementation of the
round
function:https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.round.html#pandas.DataFrame.round
Observations:
An implementation of the
count
function:Observations:
An implementation of the
std
function:https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.std.html#pandas.DataFrame.std
General
src/pykx/pykx.q
andsrc/pykx/reimporter.py
src/pykx/util.py
logic which is used for environment variable.zip
been updatedCode
Testing
Documentation
.md
file associated with it been created?mkdocs.yml