KxSystems / pykx

PyKX is a Python first interface to the worlds fastest time-series database kdb+ and it's underlying vector programming language q.
https://code.kx.com/pykx
Other
45 stars 10 forks source link

Addition of skew, add_prefix, add_suffix, count, std functions #16

Closed nipsn closed 6 months ago

nipsn commented 7 months ago

Feature

What does this change introduce?

An implementation of the skew function: https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.skew.html#pandas.DataFrame.skew

An implementation of the add_prefix and add_suffix function: https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.add_prefix.html https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.add_suffix.html

Observations:

An implementation of the count function:

Observations:

An implementation of the std function:

https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.std.html#pandas.DataFrame.std

General

Code

Testing

Documentation

nipsn commented 7 months ago

@cmccarthy1 @rianoc-kx Please review our contributions and feel free to give any kind of feedback. Thanks in advance.

cmccarthy1 commented 6 months ago

Thanks for the changes @marcosvm13, I've approved but @rianoc-kx will need to approve this week additionally to get this included in the next release, we'll look to get this done this week for release with our 2.3 release coming up next week

rianoc-kx commented 6 months ago

I had made my suggested fixes and created a pull request to your repo to review

https://github.com/hablapps/pykx/pull/31

We will be doing a larger refactor of PyKX in a similar fashion to use cleaner q code instead of building F-strings which make the code hard to read and refactor.