search

KxSystems / pyq

PyQ — Python for kdb+
http://code.kx.com/q/interfaces
Apache License 2.0
191 stars 49 forks source link

Removed force for KDB 32-bit on mac OS. #13

Closed joeloliver closed 7 years ago

joeloliver commented 7 years ago

I have been tested on macOS 64-bit with KDB 64-bit and it looks fine.

abalkin commented 7 years ago

@t4joel - Thank you for your contribution. We have made significant changes to setup.py in our private development branch, so your PR cannot be merged. Nevertheless, we should be able to accommodate your needs in the next release.

The current logic in the development branch is

    bits = (sys.maxsize + 1).bit_length()
    sysname = platform.system()
    machine = platform.machine()

    if sysname == 'Darwin':
        m64dir = os.path.join(q_home, 'm64')
        if not os.path.isdir(m64dir):
            bits = 32

Note that on macOS, setup.py is typically run by a 64-bit Python, but users of the free edition kdb+ only have m32 installed. Does the logic above (force 32 bits only when m64 is missing in QHOME) satisfy your needs?

joeloliver commented 7 years ago

Awesome, thank you very much.

sashkab commented 7 years ago

Code responsible for forcing 32-bit kdb+ version on macOS has been removed in PyQ 4.1.0.