KxmischesDomi / MoreAxolotls

Adds many new realistic axolotl types
https://www.curseforge.com/minecraft/mc-mods/more-axolotls
Other
2 stars 0 forks source link

Make an API so other people could add more variants #1

Closed AkashiiKun closed 2 years ago

AkashiiKun commented 2 years ago

Hi, you might know me as i am the creator of More Axolotl Variants Mod. Your mod is way better than mine and i would like if you provide an API so i could adapt my mod as an addon of yours. Thanks.

KxmischesDomi commented 2 years ago

I could make a data driven api to add new axolotls but I don't think you should like delete your mod and only implement that api because why would you do that? Your mod works completely fine and there is now reason to do so.

AkashiiKun commented 2 years ago

You got me wrong, i would use your mod as an API to extend my mod, that's the point.

KxmischesDomi commented 2 years ago

What do you wanna do?

KxmischesDomi commented 2 years ago

Like what are you trying to archieve with this api what your mod currently doesn't do?

AkashiiKun commented 2 years ago

Basically my mod only adds new variants (and the exception of the glowxolotl that also implements a LambDynamicLights + custom sounds and particles to the variant), your mod is pretty advanced compared to mine. I don't want to "steal" your code to implement into mine, i'd rather use an API so both mods can coexists with extra compatibility.

KxmischesDomi commented 2 years ago

So you also add custom particles and sound to the glowing axolotl, mine doesn't do that. So what's more advanced at my mod? That I also add bucket variants that are compatible with the other axolotl bucket mod and your mod? Or that I use variant id's that are not directly after the vanilla ones to avoid problems with other mods when installed / uninstalled? Doesn't your mod also has a forge version so you shouldn't depend on an api from a fabric only mod?

AkashiiKun commented 2 years ago

I'm not planning on update the forge version.

AkashiiKun commented 2 years ago

Also my mod adds the variants dynamically, detects the last variant number and adds the new ones after the last one in order.

AkashiiKun commented 2 years ago

ArrayList variants = new ArrayList<>(Arrays.asList(field_28350));

    Variant last = (Variant) variants.get(variants.size() - 1);
    int i = 1;
vraxxda commented 2 years ago

Hi, you might know me as i am the creator of More Axolotl Variants Mod. Your mod is way better than mine and i would like if you provide an API so i could adapt my mod as an addon of yours. Thanks.

I think im late to quote that but, More Axolotls mod already have compatibility with your mod (mention on CurseForge page)...

So why did you need a api for?

AkashiiKun commented 2 years ago

Is not about compatibility but to extend my mod's features

AkashiiKun commented 2 years ago

Mostly the breeding features

AkashiiKun commented 2 years ago

Is that hard to understand? APIs are not only to do compatibility but to extend other mods' features

AkashiiKun commented 2 years ago

I'm using LambDynamicLights API to make glowxolotl emit light when using LDL.

vraxxda commented 2 years ago

I understand now, thanks for explaining :) i was a lil confused

AkashiiKun commented 2 years ago

It's fine ^w^