KyaniteMods / DeeperAndDarker

Adding more to Minecraft's Deep Dark!
https://www.curseforge.com/minecraft/mc-mods/deeperdarker
GNU Affero General Public License v3.0
75 stars 25 forks source link

Tags not properly updated to 1.21 #344

Closed Shnupbups closed 3 weeks ago

Shnupbups commented 3 weeks ago

Minecraft Version: 1.21.x Mod Version: 1.3.1 Mod Loader: neoforge/forge/fabric

Description: As part of 1.21, Mojang changed the directories for various tags to use singular names instead of plural.

Your mod uses tags in one or more of the old directories that was changed! This means those tag files will no longer load in 1.21 unless you update the directories!

The affected directories and their new counterparts are:

Please ensure that any of these that you are using is updated to the new name in all namespaces (including your own, minecraft, and c).

NewJumper commented 3 weeks ago

why did you target neo, forge, fabric. Dont just assume because one version doesnt do it, all versions dont. Also, I assume you're talking about fabric?

Shnupbups commented 3 weeks ago

This is a vanilla change in 1.21. It affects every mod, regardless of loader.

Amusing that you write "Don't just assume" and then immediately follow it with "Also I assume you're talking about fabric"...

NewJumper commented 3 weeks ago

As modders, we are well aware of what changes Minecraft does. However, your issue made it seem like it was an issue with all the modloaders, which it wasnt.

Pedro270707 commented 3 weeks ago

Fixed https://github.com/KyaniteMods/DeeperAndDarker/commit/ee623c8882be9c289f611906cf06b9728698e588 Thanks for reporting!